Skip to content

revert code under optimization when optimization found [CF-685] #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

revert code under optimization when optimization found [CF-685] #520

merged 1 commit into from
Jul 7, 2025

Conversation

@misrasaurabh1
Copy link
Contributor

@misrasaurabh1 misrasaurabh1 commented Jul 7, 2025 •
edited by github-actions bot
Loading

PR Type

Enhancement

Description

  • Add --replay-test flag to write condition

  • Expand condition to multi-line format

Changes walkthrough 📝

Relevant files
Enhancement
function_optimizer.py
Include replay_test flag in write condition                           

codeflash/optimization/function_optimizer.py

  • Added self.args.replay_test to conditional logic
  • Reformatted condition into multi-line block
    		• +6/-1     
    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
    •

    @github-actions
    Copy link

    github-actions bot commented Jul 7, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Missing Tests

    Add tests covering behavior when --replay-test is set to ensure write_code_and_helpers is invoked as expected.

     
    if (
    self.args.all
    or env_utils.get_pr_number()
    or self.args.replay_test
    or (self.args.file and not self.args.function)
):
    Args Validation

    Verify that self.args.replay_test is always defined (with a default) to avoid potential AttributeError.

     
    if (
    self.args.all
    or env_utils.get_pr_number()
    or self.args.replay_test
    or (self.args.file and not self.args.function)
):
    Condition Clarity

    Consider extracting the long compound if condition into a named boolean variable for readability and easier maintenance.

     
    if (
    self.args.all
    or env_utils.get_pr_number()
    or self.args.replay_test
    or (self.args.file and not self.args.function)
):

    @github-actions
    Copy link

    github-actions bot commented Jul 7, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Avoid missing replay_test error

    Use safe attribute access for replay_test to avoid an AttributeError when the flag
    isn't defined. Replace direct attribute access with getattr and a default False.

    codeflash/optimization/function_optimizer.py [1050-1055]

     if (
     self.args.all
     or env_utils.get_pr_number()
-    or self.args.replay_test
+    or getattr(self.args, 'replay_test', False)
     or (self.args.file and not self.args.function)
 ):
    Suggestion importance[1-10]: 6

    __

    Why: The use of getattr(self.args, 'replay_test', False) safely handles cases where replay_test may not be defined, preventing potential AttributeError without significant code change.

    		Low

    @misrasaurabh1 misrasaurabh1 changed the title revert code under optimization when optimization found revert code under optimization when optimization found [CF-685] Jul 7, 2025
    @misrasaurabh1 misrasaurabh1 merged commit ab32de0 into main Jul 7, 2025
    17 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    Review effort 2/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    @misrasaurabh1